Closed
Conversation
add DP implementation and improve recursive version
for more information, see https://pre-commit.ci
replace lru_cache with cache and fix line length
Member
|
Closing tests_are_failing PRs to prepare for Hacktoberfest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added an enhanced implementation of the 0-N Knapsack Problem that includes both:
functools.cache)The code now adheres to PEP 8 and Ruff style rules, replacing
@lru_cache(maxsize=None)with@cache(UP033) and ensuring all lines are ≤ 88 characters (E501).Additionally, the function API has been simplified — the redundant
counterparameter was removed, and a newmethodargument was added to choose between'recursive'and'dp'implementations.Doctests and documentation have been updated to reflect these improvements.
Checklist: